Re: Discussion - Search Objects

On Thu, Jun 16, 2011 at 8:48 PM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:
> On Wed, 2011-06-15 at 23:48 +0200, Jasmin Dizdarevic wrote:
>> Yeah, I know. All of the dialogs have a "binding" to some pgObject,
>> because all of them modifies something.
>
> No, see dlgFindAndReplace.

Yeah, back in the early days there was some confusion about what was a
form (window) and what was a dialog - I don't want to add to that now.

In pgAdmin virtually all of our dialogues are actually more like
regular windows because they are sizeable. That's a conscious
decision, made for reasons of usability and consistency. With that in
mind, I consider forms to be the "main" application windows, eg.
frmMain, frmQuery, frmDebugger, frmStatus and so on. Everything else
is a dialogue - a popup to perform a quick task eg. vacuum, backup or
search/replace, to adjust program options (frmOptions is one of the
mistakes!), or to define/display properties of a database object.

>> btw: You could help me with the factory class. Am I starting the
>> dialog correctly?
>>
>
> Seems good to me. My only question is: why in frmMain.ccp and not in
> frmSearchObject.cpp? I first tried the latter, and was surprised to find
> it in the former.

Yeah, the factories should typically be in the same source file as the
dialogue they're responsible for creating.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company