Re: synchronous_commit and synchronous_replication Re: [COMMITTERS] pgsql: Efficient transaction-controlled synchronous replication.

On Mon, Apr 4, 2011 at 4:25 PM, Robert Haas <robertmhaas@gmail.com> wrote:
>>> I'm OK with this.
>>
>> The attached patch merges synchronous_replication into synchronous_commit.
>> With the patch, valid values of synchronous_commit are "on" (waits for local
>> flush and sync rep), "off" (waits for neither local flush nor sync
>> rep), and "local"
>> (waits for only local flush).
>
> Committed with some additional hacking.  In particular, I believe that
> your version made SYNCHRONOUS_COMMIT_LOCAL equivalent to
> SYNCHRONOUS_COMMIT_OFF, which was wrong; and your replacement of
> synchronous_replication by synchronous_commit in the docs was a bit
> too formulaic; in particular, the section on setting up a basic sync
> rep configuration said that all you needed to do was set
> synchronous_commit=on, which clearly made no sense, since that was
> neither necessary (since that's the default) nor sufficient (since you
> have to set synchronous_standby_names).

Err, woops.  Actually, I'm wrong about the first point: your coding
worked, but I had to adjust it when I reordered the enum.  I think the
new ordering is more logical, but YMMV.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company