Re: Rework on the dialogs UI

On Thu, Apr 7, 2011 at 2:57 PM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:
>>> - The catalog properties dialogue crashes horribly.
>>>
>>
>> It doesn't crash on my laptop (I tried with information_schema and
>> pg_catalog on a PostgreSQL HEAD).
>>
>
> Still didn't reproduce it.

When it opens I can briefly see the cancel button at the top left
before it crashes, then:

Exception Type:  EXC_BAD_ACCESS (SIGBUS)
Exception Codes: KERN_PROTECTION_FAILURE at 0x00000000000001c8
Crashed Thread:  0  Dispatch queue: com.apple.main-thread

Thread 0 Crashed:  Dispatch queue: com.apple.main-thread
0   pgAdmin3-Debug                    0x00173f08
dlgSecurityProperty::OnChangeSize(wxSizeEvent&) + 24
1   libwx_base_carbonu-2.8.dylib      0x014e24d3
wxEvtHandler::ProcessEventIfMatches(wxEventTableEntryBase const&,
wxEvtHandler*, wxEvent&) + 131
2   libwx_base_carbonu-2.8.dylib      0x014e2b51
wxEventHashTable::HandleEvent(wxEvent&, wxEvtHandler*) + 113
3   libwx_base_carbonu-2.8.dylib      0x014e2e7f
wxEvtHandler::ProcessEvent(wxEvent&) + 207
4   libwx_macu_core-2.8.dylib         0x0102ea3d
wxTopLevelWindowMac::Show(bool) + 397
5   libwx_macu_core-2.8.dylib         0x00fe1d3d wxDialog::Show(bool) + 45
6   pgAdmin3-Debug                    0x0017c47b dlgProperty::Go(bool) + 4155
7   pgAdmin3-Debug                    0x0017cd36
dlgDefaultSecurityProperty::Go(bool, bool, wxString const&, wxString
const&, wxString const&) + 38
8   pgAdmin3-Debug                    0x0019235a dlgSchema::Go(bool) + 474
9   pgAdmin3-Debug                    0x0017a37f
dlgProperty::EditObjectDialog(frmMain*, ctlSQLBox*, pgObject*) + 559
10  pgAdmin3-Debug                    0x0017a6f3
propertyFactory::StartDialog(frmMain*, pgObject*) + 35
11  pgAdmin3-Debug                    0x001fb316
frmMain::OnAction(wxCommandEvent&) + 70
...
...

>>> - Have you come up with a new set of standard sizes?
>>>
>>
>> Yeah, two sizes:
>>
>>  * small one: 220,250
>
> new small size is 250,250

I wonder if it should be 300 wide? The tab labels are all visible now,
but the edges aren't.

>>  * big one: 270,250
>>
>> But it seems I forgot dlgServer and dlgTable. Just fixed dlgServer.
>> Working on dlgTable right now.
>>
>
> Fixed too.

:-)

> I fixed also the frmOptions window.

Not quite - see the attached screenshot.

BTW, that one also seems to be missing the status bar. Wanna fix that
while you're there?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company