Fix PGPORT reassignment in ecpg regression tests
От | Michael Glaesemann |
---|---|
Тема | Fix PGPORT reassignment in ecpg regression tests |
Дата | |
Msg-id | B6830359-7DB3-4443-8046-8129E2D91E7F@seespotcode.net обсуждение исходный текст |
Ответы |
Re: Fix PGPORT reassignment in ecpg regression tests
|
Список | pgsql-patches |
The pg_regress.sh script for ecpg regression tests checks to make sure the port number is between 1024 and 65535. If it isn't, it uses 65432. (c310-315. This is the same behavior as the standard regression tests, I believe.) However, it if does reassign the port number, it was changing it back to the original, supplied port number after creating the installation. This would cause the tests to fail as the tests were run against a different port (the original supplied port) while the server was listening on 65432. This patch removes the subsequent assignment back to the original port number. Passes both the standard regression tests and, more importantly, those for ecpg, with normal and abnormally high port numbers. Michael Glaesemann grzm seespotcode net Index: src/interfaces/ecpg/test/pg_regress.sh =================================================================== RCS file: /projects/cvsroot/pgsql/src/interfaces/ecpg/test/ pg_regress.sh,v retrieving revision 1.9 diff -c -r1.9 pg_regress.sh *** src/interfaces/ecpg/test/pg_regress.sh 29 Aug 2006 13:23:26 -0000 1.9 --- src/interfaces/ecpg/test/pg_regress.sh 4 Sep 2006 14:22:17 -0000 *************** *** 644,650 **** if [ x"$temp_install" != x"" ] then do_temp_install - PGPORT=$temp_port; export PGPORT else # not temp-install dont_temp_install fi --- 644,649 ----
В списке pgsql-patches по дате отправления: