Re: Review: Re: [PATCH] Re: Adding xpath_exists function
| От | Robert Haas |
|---|---|
| Тема | Re: Review: Re: [PATCH] Re: Adding xpath_exists function |
| Дата | |
| Msg-id | AANLkTinqV-LqCN1dGjf6TdqgXiFQ3Sc-deWr7a8LRCBV@mail.gmail.com обсуждение исходный текст |
| Ответ на | Review: Re: [PATCH] Re: Adding xpath_exists function (David Fetter <david@fetter.org>) |
| Ответы |
Re: [RRR] Review: Re: [PATCH] Re: Adding xpath_exists
function
|
| Список | pgsql-hackers |
On Tue, Jul 27, 2010 at 7:33 PM, David Fetter <david@fetter.org> wrote:
> Minor quibble with the regression tests: should we be using
> dollar quotes in things like this? Doubled-up quote marks:
>
> SELECT xpath_exists('//town[text() =
''Cwmbran'']','<towns><town>Bidford-on-Avon</town><town>Cwmbran</town><town>Bristol</town></towns>'::xml);
>
> Dollar quote:
>
> SELECT xpath_exists($$//town[text() =
'Cwmbran']$$,'<towns><town>Bidford-on-Avon</town><town>Cwmbran</town><town>Bristol</town></towns>'::xml);
Personally, I don't really see that as an improvement. Dollar-quotes
are really nice for longer strings, or where you would otherwise have
quadrupled quotes (or more), but I don't see a big advantage to it
here. Still, it's a question of opinion more than anything else.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company
В списке pgsql-hackers по дате отправления: