Re: refactoring comment.c

On Fri, Aug 27, 2010 at 4:16 PM, Peter Eisentraut <peter_e@gmx.net> wrote:
> On fre, 2010-08-27 at 07:49 -0400, Robert Haas wrote:
>> Anyway, committed.
>
> I suppose this is responsible for this:
>
> gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith
> -Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing
> -fwrapv -g -Werror -Wno-inline -I../../../src/include -D_GNU_SOURCE
> -I/usr/include/libxml2   -c -o objectaddress.o objectaddress.c -MMD -MP
> -MF .deps/objectaddress.Po
> cc1: warnings being treated as errors
> objectaddress.c: In function ‘get_object_address’:
> objectaddress.c:102: error: ‘address.objectId’ may be used uninitialized
> in this function
> objectaddress.c:102: error: ‘address.classId’ may be used uninitialized
> in this function
> make[1]: *** [objectaddress.o] Error 1

I suppose this is unhappy because it things elog(ERROR) might return?
For whatever reason, I don't get this on my machine.  But I'll try
plugging that hole and perhaps that will fix it.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company