Re: Invalid YAML output from EXPLAIN
От | Robert Haas |
---|---|
Тема | Re: Invalid YAML output from EXPLAIN |
Дата | |
Msg-id | AANLkTinfZDxa8BHnVWdNfeiYr-bp1bXISj2fs7016EMA@mail.gmail.com обсуждение исходный текст |
Ответ на | Invalid YAML output from EXPLAIN (Dean Rasheed <dean.a.rasheed@gmail.com>) |
Ответы |
Re: Invalid YAML output from EXPLAIN
|
Список | pgsql-bugs |
On Wed, Jun 9, 2010 at 4:47 PM, Dean Rasheed <dean.a.rasheed@gmail.com> wro= te: > On 9 June 2010 20:56, Robert Haas <robertmhaas@gmail.com> wrote: >> On Wed, Jun 9, 2010 at 3:50 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote: >>> Dean Rasheed <dean.a.rasheed@gmail.com> writes: >>>> Hmm. Well it's quite subjective, but IMO it's already more readable >>>> than JSON regardless of whether or not values are quoted, simply >>>> because it doesn't have [ ] and { } for lists and maps, which for JSON >>>> adds significantly to the number of lines in longer plans. >>> >>> Yeah. =A0Also, I think it would be fair to not quote values that are kn= own >>> constants (for example, Node Type: Seq Scan) and are chosen to not need >>> quoting. =A0It's just the things that are variables that worry me. >> >> Passing down information about which things are known constants seems >> more complicated to me than just getting the quoting rules right in >> the first place. =A0If you look at the patch I proposed, you'll see that >> it's really quite simple and only a slight tightening of what I >> committed already. >> > > Reading the YAML spec, I've just spotted yet another case that'll > break what you're proposing: if you don't quote "true" and "false", > the parser will think they're booleans rather than strings. > > This is really why I'm opposed to this approach. There are just so > many gotchas that it's impossible to be 100% sure that you've > accounted for them all. OK, I give up. --=20 Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company
В списке pgsql-bugs по дате отправления: