Re: Issue with libpq < 8.4

On Thu, Aug 26, 2010 at 10:51 AM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:
> Le 26/08/2010 11:49, Dave Page a écrit :
>> On Thu, Aug 26, 2010 at 10:48 AM, Guillaume Lelarge
>> <guillaume@lelarge.info> wrote:
>>> What I've come to is this patch. Actually, and quite surprisingly, it
>>> doesn't work. I have no idea why. The configure script finds if we have
>>> or not the PQconninfoParse function(), but the #ifdef in pgConn source
>>> file doesn't seem to do what it has to. I always get a build without
>>> PQconninfoParse, wether configure founds it or not.
>>>
>>> Any ideas on what I did wrong?
>>
>> EPATCHNOTFOUND
>>
>
> Oops, time to get some coffee, as you already said :)

There's two ways you can fix it. To match what we do for SSL support:

In acinclude.m4, you don't need to use AC_SUBST, and you do need to
add something like:

                if test "$PG_SSL" = "yes"
                then
                        CPPFLAGS="$CPPFLAGS -DSSL"
                fi

but for HAVE_CONNINFOPARSE (yes, I know we should probably do this in
CXXFLAGS, but now is not the time to fix the build system :-p ).

The other way uses AC_SUBST to add the variable to the Makefile (which
you did). You can then use that variable in Makefile.am to
conditionally add the -DHAVE_CONNINFOPARSE. Iirc, that's similar to
have we deal with the options to build an appbundle.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgres Company