Re: Fix for Index Advisor related hooks
| От | Gurjeet Singh |
|---|---|
| Тема | Re: Fix for Index Advisor related hooks |
| Дата | |
| Msg-id | AANLkTinRFCWMweztTCfY5-9TMnjxfgCdKCQ9r+HT85R4@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: Fix for Index Advisor related hooks (Tom Lane <tgl@sss.pgh.pa.us>) |
| Ответы |
Re: Fix for Index Advisor related hooks
|
| Список | pgsql-hackers |
On Tue, Feb 15, 2011 at 11:59 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
I understand that we need to hide guts of an implementation. But without this the Index Advisor will have to emulate what LookupOpclassInfo() does and that's a lot of code that I am afraid, if emulated by another function in Index Advisor, is more prone to obsolecence than calling IndexSupportInitialize().
Gurjeet Singh <singh.gurjeet@gmail.com> writes:We are *not* doing that. That's a private function and will remain so.
> Also attached is the patch expose_IndexSupportInitialize.patch, that makes
> the static function IndexSupportInitialize() global so that the Index
> Advisor doesn't have to reinvent the wheel to prepare an index structure
> with opfamilies and opclasses.
I understand that we need to hide guts of an implementation. But without this the Index Advisor will have to emulate what LookupOpclassInfo() does and that's a lot of code that I am afraid, if emulated by another function in Index Advisor, is more prone to obsolecence than calling IndexSupportInitialize().
Regards,
--
gurjeet.singh
@ EnterpriseDB - The Enterprise Postgres Company
http://www.EnterpriseDB.com
singh.gurjeet@{ gmail | yahoo }.com
Twitter/Skype: singh_gurjeet
Mail sent from my BlackLaptop device
В списке pgsql-hackers по дате отправления: