Re: Patch to support SSL certificate connections

On Thu, Jan 27, 2011 at 9:56 PM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:
> Le 22/01/2011 01:34, Guillaume Lelarge a écrit :
>> Le 21/01/2011 10:17, Magnus Hagander a écrit :
>>> On Thu, Jan 20, 2011 at 23:08, Guillaume Lelarge <guillaume@lelarge.info> wrote:
>>>> Le 19/01/2011 00:35, Guillaume Lelarge a écrit :
>>>>> Hi,
>>>>>
>>>>> This patch adds support to specify SSL certificate files and to connect
>>>>> according to those.
>>>>>
>>>>> It's pretty straightforward: four file pickers to handle on dlgServer,
>>>>> and changes in the connection code to add those parameters in the
>>>>> connection string.
>>>>>
>>>>
>>>> A screenshot attached so that you can see the UI without building pgAdmin :)
>>>>
>>>> Comments?
>>>
>>> I would move root cert up before the others. Also CRL.
>>>
>>> Root cert and CRL are about validating the *server* certificate. Key
>>> and cert file are about SSL authentication of the *client* (thus
>>> *client* certificates). They should definitely be in that order -
>>> perhaps even grouped with a headline?
>>>
>>
>> Done for moving widgets. Not sure grouped widgets could make sense here.
>>
>
> Here is what I finally managed to do. Comments?

Why the change from the standard layout used everywhere else?



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company