Re: PgAdmin III 1.12 crazy memory usage

On 12 October 2010 10:41, Dave Page <dpage@pgadmin.org> wrote:
> On Thu, Oct 7, 2010 at 4:59 PM, Guillaume Lelarge
> <guillaume@lelarge.info> wrote:
>> Le 07/10/2010 13:56, Dave Page a écrit :
>>> On Tue, Oct 5, 2010 at 11:03 AM, Thom Brown <thom@linux.com> wrote:
>>>> Okay, I've tried reproducing it by asking it to show the edit view
>>>> without restricting the number of results, but seems to be fine.  But
>>>> if I open with limited to 100, then change it to "no limit", refresh
>>>> and close, the query still appears to be running on the server.  It
>>>> shows "pgAdmin III - Edit Grid" as the process running the query too,
>>>> and there's still lots of I/O on the machine.  I definitely don't
>>>> still have that window open.
>>>
>>> OK, so I believe the attached patch fixes this, though I'm slightly
>>> nervous about unintended side-effects. I'll provide Thom with a binary
>>> for testing, but would appreciate it if someone else (Guillaume?)
>>> could also review the patch.
>>>
>>
>> Seems good to me. I don't find any side-effects on this patch. So +1 to
>> commit it.
>
> Done.

Thanks Dave.

--
Thom Brown
Twitter: @darkixion
IRC (freenode): dark_ixion
Registered Linux user: #516935