Seems like a bugfix, even if thd behaviour changes.
On 12/25/10, Guillaume Lelarge <guillaume@lelarge.info> wrote:
> Le 23/12/2010 00:31, Dave Page a écrit :
>> On Thu, Dec 23, 2010 at 12:05 AM, Guillaume Lelarge
>> <guillaume@lelarge.info> wrote:
>>> Le 22/12/2010 10:26, Dave Page a écrit :
>>>> On Wed, Dec 22, 2010 at 10:15 AM, Guillaume Lelarge
>>>> <guillaume@lelarge.info> wrote:
>>>>> Le 22/12/2010 09:47, Dave Page a écrit :
>>>>>> Guillaume; do we have a limit on the size of data we'll store in the
>>>>>> history file? We've seen 3 or 4 reports like this.
>>>>>>
>>>>>
>>>>> The Options dialog says yes (1024 characters). But, AFAICT from reading
>>>>> the source code, we don't use it :-/ I was sure we did. Will fix it
>>>>> today.
>>>>
>>>> Oops.
>>>>
>>>
>>> I looked a bit more at this issue. We use the option. The flow of
>>> operations is:
>>> * put the query in the combobox and the file
>>> * execute the query
>>> * if the query fails, delete it from the combobox and the file
>>> * if it's bigger than the max size, delete it from combobox and file
>>>
>>> The reasoning behind all this is to still be able to look at your query
>>> if it crashes pgAdmin. So you don't have to type it again. You just need
>>> to select it in the combobox and fix it.
>>
>> We can still limit the size of query written to the file. If you want
>> crash protection, use a temp file or something, rather than trying to
>> overload that on the history mechanism. If the file exists when the
>> query tool is reloaded, load the file (like word or openoffice do).
>>
>> Those really are two different functions...
>>
>
> I agree. Don't know why I mixed the two. So I have a new patch
> (attached). It changes the current behaviour.
>
> Current behaviour:
>
> When query is launched
> Save query
> When query is done
> If unsuccessul
> Delete query
> If successful
> If it's bigger than max size
> Delete query
> Else if already present
> Delete the old one
>
> New behaviour
>
> When query is done
> If successful
> If it's less than max size
> Add query
> If already present
> Delete the old one
>
> This really changes the behaviour. I wrote the patch for the 1.12
> branch, but I'm not sure we really want it there. So, only master, or
> master and 1.12?
>
>
> --
> Guillaume
> http://www.postgresql.fr
> http://dalibo.com
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company