Re: [COMMITTERS] pgsql: Properly install gram.h on MSVC builds

On Sun, Jan 9, 2011 at 17:49, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Magnus Hagander <magnus@hagander.net> writes:
>> On Sun, Jan 9, 2011 at 17:31, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> I'd like to protest this patch as misguided.  AFAICS it is a *seriously*
>
>> Uh, we install the file on Unix, so we should do the same on Windows.
>
> Well, my idea of how to fix that would be the other way 'round.

Sure, then it's at least consistent...


>>> What we really need to be asking is why the pgAdmin folks think
>>> they should be including it.
>
>> It is required in order to pull kwlist.h,
>
> No, it is not required.  What they should be doing is #define'ing
> PG_KEYWORD() in a way that ignores its second argument.  See pg_dump's
> keywords.c for an example of safe usage.

Ahh, good point.

And yes, that seems to work for pgadmin. I'll commit a patch there as
soon as I've finished testing, at which point it won't be required
anymore.


--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/