On Thu, Dec 23, 2010 at 12:05 AM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:
> Le 22/12/2010 10:26, Dave Page a écrit :
>> On Wed, Dec 22, 2010 at 10:15 AM, Guillaume Lelarge
>> <guillaume@lelarge.info> wrote:
>>> Le 22/12/2010 09:47, Dave Page a écrit :
>>>> Guillaume; do we have a limit on the size of data we'll store in the
>>>> history file? We've seen 3 or 4 reports like this.
>>>>
>>>
>>> The Options dialog says yes (1024 characters). But, AFAICT from reading
>>> the source code, we don't use it :-/ I was sure we did. Will fix it today.
>>
>> Oops.
>>
>
> I looked a bit more at this issue. We use the option. The flow of
> operations is:
> * put the query in the combobox and the file
> * execute the query
> * if the query fails, delete it from the combobox and the file
> * if it's bigger than the max size, delete it from combobox and file
>
> The reasoning behind all this is to still be able to look at your query
> if it crashes pgAdmin. So you don't have to type it again. You just need
> to select it in the combobox and fix it.
We can still limit the size of query written to the file. If you want
crash protection, use a temp file or something, rather than trying to
overload that on the history mechanism. If the file exists when the
query tool is reloaded, load the file (like word or openoffice do).
Those really are two different functions...
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company