Re: patch: utf8_to_unicode (trivial)

On Sun, Aug 15, 2010 at 7:49 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Joseph Adams <joeyadams3.14159@gmail.com> writes:
>> I've attached another patch that moves utf8_to_unicode to src/port per
>> Robert Haas's suggestion.
>
>> This patch itself is not quite as elegant as the first one because it
>> puts platform-independent code that "belongs" in wchar.c into src/port
>> .  It also uses unsigned int instead of pg_wchar because the typedef
>> of pg_wchar isn't available to the frontend, if I'm not mistaken.
>
>> I'm not sure whether I like the old patch better or the new one.
>
> FWIW, I *don't* like this version, specifically because it fails to
> utilize the pg_wchar datatype.  The function in question is neither big
> enough nor mutable enough that it's urgent to not duplicate it between
> the backend and psql, so I don't see much value in moving it to src/port.

Well, we'd better at least add a comment noting that the two versions
should match.  But I think it would be better to unify them.  However,
in the back-branches, I'd just fix the incorrect copy.

YMMV.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company