Re: pgAdmin III commit: Include a variant of sysSettings::Write() that take

On 16 February 2011 15:47, Dave Page <dpage@pgadmin.org> wrote:
> Include a variant of sysSettings::Write() that takes a wxChar* value
> to write, as they are currently being cast to bools and stored as
> true/false.

I anticipated this, and my latest patch doesn't have this problem -
it's the same situation as ctlListView, where we changed
AppendItem(const wxString&, bool) to AppendYesNoItem(const wxString&,
bool). I changed bool Write(const wxString&, bool) to bool
WriteBool(const wxString&, bool) in sysSettings's case.

I think that we perhaps overload too much in both of those classes.
The only reason that a call like this doesn't work with my code
presently:

sysSettings foo;
foo.Write(true);

is because we have an ambiguous conversion error (should it be a long
or an int?).


--
Regards,
Peter Geoghegan