Re: SQL/MED - file_fdw

On Mon, Dec 20, 2010 at 6:42 AM, Itagaki Takahiro
<itagaki.takahiro@gmail.com> wrote:
> On Sun, Dec 19, 2010 at 12:45, Robert Haas <robertmhaas@gmail.com> wrote:
>> I'm not questioning any of that.  But I'd like the resulting code to
>> be as maintainable as we can make it.
>
> I added comments and moved some setup codes for COPY TO to BeginCopyTo()
> for maintainability. CopyTo() still contains parts of initialization,
> but I've not touched it yet because we don't need the arrangement for now.

I haven't analyzed this enough to know whether I agree with it, but as
a trivial matter you should certainly revert this hunk:
       /* field raw data pointers found by COPY FROM */
-
-       int max_fields;
-       char ** raw_fields;
+       int                     max_fields;
+       char      **raw_fields;


--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company