Re: [PATCH] Add SIGCHLD catch to psql
| От | Robert Haas |
|---|---|
| Тема | Re: [PATCH] Add SIGCHLD catch to psql |
| Дата | |
| Msg-id | AANLkTimOoIzT01kv_N3cmwhKofu06xIvMBl1Xg0Zm4ZZ@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: [PATCH] Add SIGCHLD catch to psql (David Fetter <david@fetter.org>) |
| Ответы |
Re: [PATCH] Add SIGCHLD catch to psql
|
| Список | pgsql-hackers |
On Sat, May 15, 2010 at 7:46 PM, David Fetter <david@fetter.org> wrote: >> > Anyway, this makes FETCH_COUNT alot more useful, and, in my view, the >> > current behaviour of completely ignoring $PAGER exiting is a bug. >> >> Plesae add this to the next commit-fest: >> >> https://commitfest.postgresql.org/action/commitfest_view/inprogress >> >> Thanks. > > Wouldn't this count as a bug fix? Possibly, but changes to signal handlers are pretty global and can sometimes have surprising side effects. I'm all in favor of someone reviewing the patch - any volunteers? One case to test might be reading input from a file that contains \! escapes. More generally, we need to consider every way that psql can get SIGCHLD and think about whether this is the right behavior. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company
В списке pgsql-hackers по дате отправления: