Re: [COMMITTERS] pgsql: Add TCP keepalive support to libpq.

On Thu, Jun 24, 2010 at 1:38 PM, Simon Riggs <simon@2ndquadrant.com> wrote:
> On Thu, 2010-06-24 at 11:15 -0400, Tom Lane wrote:
>> Florian Pflug <fgp@phlo.org> writes:
>> > On Jun 24, 2010, at 16:45 , Robert Haas wrote:
>> >> I think the existing names are fine - people should understand that
>> >> "options" means "server-side options" and that anything else is a
>> >> client-side option.  However, if there's a strong consensus the other
>> >> way and someone feels like working up a patch, that's fine too.
>>
>> > I'd volunteer to create the patch if people think renaming the libpq options is a good idea.
>>
>> I'm with Robert: the names are fine as-is.  We've not had complaints
>> about the libpq SSL parameters being confusingly like server-side SSL
>> parameters, for instance.
>>
>> It might be a good idea to add a sentence to the documentation, though,
>> just pointing out that these control client-side keepalive probes rather
>> than server-side.
>
> Yes please. I was confused; I think others will be also.

Do either of you have any thoughts about where would be the best place
to add such a sentence?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company