Re: auto-sizing wal_buffers

Поиск
Список
Период
Сортировка
От Fujii Masao
Тема Re: auto-sizing wal_buffers
Дата
Msg-id AANLkTikoUWemGmAmNGHXW8QQoo45sLxzr-aU=rUwshba@mail.gmail.com
обсуждение исходный текст
Ответ на Re: auto-sizing wal_buffers  (Greg Smith <greg@2ndquadrant.com>)
Ответы Re: auto-sizing wal_buffers
Список pgsql-hackers
Дерево обсуждения 
On Sat, Jan 15, 2011 at 3:51 PM, Greg Smith <greg@2ndquadrant.com> wrote:
> Agreed on both fronts.  Attached patch does the magic.  Also available in
> branch "walbuffers" from git://github.com/greg2ndQuadrant/postgres.git

+int            XLOGbuffersMin = 8;

XLOGbuffersMin is a fixed value. I think that defining it as a macro
rather than a variable seems better.

+        if (XLOGbuffers > 2048)
+            XLOGbuffers = 2048;

Using "XLOG_SEG_SIZE/XLOG_BLCKSZ" rather than 2048 seems
better.

+#wal_buffers = -1            # min 32kB, -1 sets based on shared_buffers

Typo: s/32kB/64kB

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

В списке pgsql-hackers по дате отправления: