Re: pg_basebackup for streaming base backups

On Tue, Jan 18, 2011 at 14:26, Alvaro Herrera
<alvherre@commandprompt.com> wrote:
> Excerpts from Magnus Hagander's message of mar ene 18 08:40:50 -0300 2011:
>> On Tue, Jan 18, 2011 at 10:49, Fujii Masao <masao.fujii@gmail.com> wrote:
>
>> > +                                       fprintf(stderr, _("%s: could not write to file '%s': %m\n"),
>> >
>> > %m in fprintf is portable?
>>
>> Hmm. I just assumed it was because we use it elsewhere, but I now see
>> we only really use it for ereport() stuff. Bottom line is, I don't
>> know - perhaps it needs to be changed to use strerror()?
>
> Some libc's (such as glibc) know about %m, others presumably don't (it's
> a GNU extension, according to my manpage).  ereport does the expansion
> by itself, see expand_fmt_string().  Probably just using strerror() is
> the easiest.

Ok, thanks for clarifying. I've updated to use strerror(). Guess it's
time for another patch, PFA :-)

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/