Re: pgsql: Basic Recovery Control functions for use in Hot Standby. Pause,

On Tue, Mar 8, 2011 at 9:20 AM, Jaime Casanova <jaime@2ndquadrant.com> wrote:
> On Tue, Feb 8, 2011 at 11:00 PM, Jaime Casanova <jaime@2ndquadrant.com> wrote:
>> On Tue, Feb 8, 2011 at 1:30 PM, Simon Riggs <simon@2ndquadrant.com> wrote:
>>> Basic Recovery Control functions for use in Hot Standby. Pause, Resume,
>>> Status check functions only. Also, new recovery.conf parameter to
>>> pause_at_recovery_target, default on.
>>>
>>
>> I guess that new parameter should also be in recovery.conf.sample, right?
>>
>
> This one is still not in recovery.conf.sample

What about the attached patch?

>> And it definitely needs to be mentioned in the docs for
>> pause_at_recovery_target that it only works in hot standby.

Done.

>>> On the second thought, I think it's useful to emit the NOTICE message when
>>> recovery reaches the pause point, as follows.
>>>
>>>     NOTICE: Recovery will not complete until pg_xlog_replay_resume() is called.
>>
>> I'm OK with adding a message, but NOTICE is the wrong level.
>>
>> My proposal is this message
>>
>> LOG:  Recovery has paused. Execute pg_xlog_replay_resume() to continue.

Done.

And, I found that <indexterm> tag has not been added for recovery
control functions
yet. So I added that into func.sgml.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center