Re: [pgAdmin4][Patch]: RM1569 - Right-clicking an disconnected EPAS server shows "Create Resource Group" option

Поиск
Список
Период
Сортировка
От Dave Page
Тема Re: [pgAdmin4][Patch]: RM1569 - Right-clicking an disconnected EPAS server shows "Create Resource Group" option
Дата
Msg-id A5A0634A-601F-47E5-9834-0572EEDAE922@pgadmin.org
обсуждение исходный текст
Ответ на [pgAdmin4][Patch]: RM1569 - Right-clicking an disconnected EPAS server shows "Create Resource Group" option  (Surinder Kumar <surinder.kumar@enterprisedb.com>)
Ответы Re: [pgAdmin4][Patch]: RM1569 - Right-clicking an disconnected EPAS server shows "Create Resource Group" option
Список pgadmin-hackers
Дерево обсуждения
Hi

That's not a reliable check - you can just as easily use postgres as the maintenance db on epas.

Why don't we just hide the option if disconnected, and if connected, then check the server type?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK:http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On 19 Aug 2016, at 19:00, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:

Hi

Issue:
Two reasons:
1) In Resource group menu, the check for server connected or not is missing.
2) When server is disconnected, server type is always set to 'pg' which is wrong and thus function always returns true.

Solution:
If server is disconnected, we should check server type based on its maintenance db.
If maintenance db is 'edb' its ppas server, otherwise 'pg'.

Please review attached patch.

Thanks,
Surinder Kumar
<RM1569.patch>

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

В списке pgadmin-hackers по дате отправления: