Re: Minor changes to Recovery related code

On Mar 30, 2007, at 5:51 PM, Florian G. Pflug wrote:
> In realitly, however, I feare that most people will just create a  
> script
> that does 'echo "select pg_stop_backup | psql"' or something similar.
> If they're a bit more carefull, they will enable ON_ERROR_STOP, and  
> check
> the return value of pgsql. I believe that those are the people who  
> would
> really benefit from a pg_stop_backup() that waits for archiving to  
> complete.
> But they probably won't check for WARNINGs.
>
> Maybe doing it the other way round would be an option?
> pg_stop_backup() could wait for the archiver to complete forever, but
> spit out a warning every 60 seconds or so "WARNING: Still waiting
> for wal archiving of wal ??? to complete". If someone really wants
> a 60-second timeout, he can just use statement_timeout.

I agree; people are far more likely to take the lazy way out, so it'd  
be good to protect against that. Esp. since statement_timeout  
provides a means to get the other behavior.
--
Jim Nasby                                            jim@nasby.net
EnterpriseDB      http://enterprisedb.com      512.569.9461 (cell)