Re: multi-threaded pgbench

On Jul 18, 2009, at 3:40 PM, Greg Stark <gsstark@mit.edu> wrote:

> On Sat, Jul 18, 2009 at 8:25 PM, Robert Haas<robertmhaas@gmail.com>  
> wrote:
>> On Thu, Jul 9, 2009 at 4:51 AM, Itagaki
>> Takahiro<itagaki.takahiro@oss.ntt.co.jp> wrote:
>>> Here is an updated version of multi-threaded pgbench patch.
>>
>> Greg (Smith), do you have time to review this version?  If not, I  
>> will
>> assign a round-robin reviewer when one becomes available.
>
> Incidentally you could assign me something if you want.

OK.

> I gave feedback on Simon/Your join removal and the Append min/max
> patch. I don't think either has really reached any conclusive
> "finished" state though. I suppose I should mark your patch as
> "returned with feedback" even if it's mostly just "good work, keep
> going"? And the other patch isn't actually in this commitfest but I
> think we're still discussing what it should do.

Well, I think we really need Tom to look at join removal. If he  
doesn't have any better ideas for how to structure the code it's not  
clear to me that we shouldn't just commit what I already did  and then  
start future work from there. But this seems like an issue for that  
thread rather than this one.

Wrt append min/max I think we should postpone further discussion until  
end of commitfest, since it was submitted mid-CommitFest.

...Robert