Re: mingw regression test fixes

Peter, did you mean $host_platform by any chance... as originally submitted?
I see no use of $build_platform anywhere, and as committed this plain fails.

I don't see why there is any need for discussion over this. There are 3
cases statements preceding this one, all of which use $host_platform. The
one immediately preceding it does the very same thing for DIFFFLAGS!

Although perhaps this was the point you were trying to make, and Bruce took
you a little too literally?

Cheers,
Claudio



> -----Original Message-----
> From: Peter Eisentraut [mailto:peter_e@gmx.net]
> Sent: Monday, 3 May 2004 6:18 AM
> To: Bruce Momjian; Andrew Dunstan
> Cc: claudio.natoli@memetrics.com; pgsql-patches@postgresql.org
> Subject: Re: [PATCHES] mingw regression test fixes
>
>
> Bruce Momjian wrote:
> > OK, I have made this adjustment.  Thanks.
>
> $build_platform would be more correct.  It keeps everything
> consistent.
>
> >
> >
> ---------------------------------------------------------------------
> >------
> >
> > Andrew Dunstan wrote:
> > > Claudio Natoli said:
> > > > For application to HEAD.
> > > >
> > > > As Andrew Dunstan appears to have cracked the regression test
> > > > buffering nut, this patch makes sure that:
> > > > * correct platform specific regression files are used under ming
> > > > * pwd prints out a usable win32 pathname
> > >
> > > Claudio,
> > >
> > > I'm assuming that you have checked that this works, as it is
> > > slightly different from what I did.
> > >
> > > Strictly speaking, the pwd flags test should probably
> depend in the
> > > test platform rather than the target platform. Something like:
> > >
> > >  case `uname` in
> > >      MINGW32*)
> > >          PWDFLAGS=-W;;
> > >      *)
> > >          PWDFLAGS=;;
> > >  esac
> > >
> > > I made that adjustment to what I was doing late in the day, but
> > > didn't have time to do a revised patch before I had to do other
> > > things.
> > >
> > > cheers
> > >
> > > andrew
> > >
> > >
> > >
> > >
> > > ---------------------------(end of
> > > broadcast)--------------------------- TIP 7: don't forget to
> > > increase your free space map settings
>

---
Certain disclaimers and policies apply to all email sent from Memetrics.
For the full text of these disclaimers and policies see
<a
href="http://www.memetrics.com/emailpolicy.html">http://www.memetrics.com/em
ailpolicy.html</a>