Re: APC/socket fix (final?)
От | Claudio Natoli |
---|---|
Тема | Re: APC/socket fix (final?) |
Дата | |
Msg-id | A02DEC4D1073D611BAE8525405FCCE2B55F3BE@harris.memetrics.local обсуждение исходный текст |
Ответ на | APC/socket fix (final?) (Claudio Natoli <claudio.natoli@memetrics.com>) |
Список | pgsql-patches |
> Ugh. Is there a way we can insert a wrapper layer without modifying the > call sites? I'm thinking of some kind of macro hack, say > [snip] Sure. Think we've even done this before (also, prevents developers needing to remember to use pg_*). The reason I think it was avoided for select(), in preference for a thread to invoke the socket op during the signal/APC, was a fear that perhaps the Windows Sockets internals could get mashed. AFAICS, the discussion Magnus had with the Microsoft guys (and, from memory, those I've had with Magnus off-list) suggests this isn't true. If mashing the internals is still a possibility, then clearly the patch I've submitted might do more harm than good. (Magnus, can you confirm?) If so, I'll submit a patch for select/recv/send over the weekend, which will also remove the recent fixes for pgstat. Cheers, Claudio --- Certain disclaimers and policies apply to all email sent from Memetrics. For the full text of these disclaimers and policies see <a href="http://www.memetrics.com/emailpolicy.html">http://www.memetrics.com/em ailpolicy.html</a>
В списке pgsql-patches по дате отправления: