Re: [HACKERS] Logical decoding on standby

On 21/12/16 04:31, Craig Ringer wrote:
> On 20 December 2016 at 15:03, Petr Jelinek <petr.jelinek@2ndquadrant.com> wrote:
> 
>> But in 0003 I don't understand following code:
>>> +     if (endpos != InvalidXLogRecPtr && !do_start_slot)
>>> +     {
>>> +             fprintf(stderr,
>>> +                             _("%s: cannot use --create-slot or --drop-slot together with --endpos\n"),
>>> +                             progname);
>>> +             fprintf(stderr, _("Try \"%s --help\" for more information.\n"),
>>> +                             progname);
>>> +             exit(1);
>>> +     }
>>
>> Why is --create-slot and --endpos not allowed together?
> 
> Actually, the test is fine, the error is just misleading due to my
> misunderstanding.
> 
> The fix is simply to change the error message to
> 
>                                 _("%s: --endpos may only be specified
> with --start\n"),
> 
> so I won't post a separate followup patch.
> 

Ah okay makes sense. The --create-slot + --endpos should definitely be
allowed combination, especially now that we can extend this to
optionally use temporary slot.

--  Petr Jelinek                  http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training &
Services