Re: GUC names in messages
От | Peter Eisentraut |
---|---|
Тема | Re: GUC names in messages |
Дата | |
Msg-id | 9e7802b2-2cf2-4c2d-b680-b2ccb9db1d2f@eisentraut.org обсуждение исходный текст |
Ответ на | Re: GUC names in messages (Peter Smith <smithpb2250@gmail.com>) |
Ответы |
Re: GUC names in messages
|
Список | pgsql-hackers |
On 08.12.23 05:10, Peter Smith wrote: > Patch 0001 -- "datestyle" becomes DateStyle in messages > Rebased this again, which was part of an earlier patch set > - I think any GUC names documented as MixedCase should keep that same > case in messages; this also obeys the guidelines recently pushed [1]. > - Some others agreed, expecting the exact GUC name (in the message) > can be found in pg_settings [2]. > - OTOH, Michael didn't like the diff churn [3] caused by this patch. I'm fine with adjusting the mixed-case stuff, but intuitively, I don't think removing the quotes in this is an improvement: - GUC_check_errdetail("Conflicting \"datestyle\" specifications."); + GUC_check_errdetail("Conflicting DateStyle specifications.");
В списке pgsql-hackers по дате отправления: