Re: consider -Wmissing-variable-declarations

On 03.08.24 22:46, Tom Lane wrote:
> Peter Eisentraut <peter@eisentraut.org> writes:
>> This has all been committed now.
> 
> Various buildfarm animals are complaining about
> 
> g++ -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla
-Werror=unguarded-availability-new-Wendif-labels -Wmissing-format-attribute -Wcast-function-type -Wformat-security
-Wmissing-variable-declarations-fno-strict-aliasing -fwrapv -fexcess-precision=standard
-Wno-unused-command-line-argument-Wno-compound-token-split-by-macro -Wno-cast-function-type-strict -g -O2
-Wno-deprecated-declarations-fPIC -fvisibility=hidden -shared -o llvmjit.so  llvmjit.o llvmjit_error.o llvmjit_inline.o
llvmjit_wrap.ollvmjit_deform.o llvmjit_expr.o -L../../../../src/port -L../../../../src/common   -L/usr/lib64
-Wl,--as-needed-Wl,-rpath,'/home/centos/17-lancehead/buildroot/HEAD/inst/lib',--enable-new-dtags  -fvisibility=hidden
-lLLVM-17
> g++: error: unrecognized command line option \342\200\230-Wmissing-variable-declarations\342\200\231; did you mean
\342\200\230-Wmissing-declarations\342\200\231?
> make[2]: *** [../../../../src/Makefile.shlib:261: llvmjit.so] Error 1
> 
> It looks like we are passing CFLAGS not CXXFLAGS to this particular
> g++ invocation.

Changing this seems to have done the trick.