Re: Fix last unitialized memory warning
От | Peter Eisentraut |
---|---|
Тема | Re: Fix last unitialized memory warning |
Дата | |
Msg-id | 967be6c7-37ca-0885-e8a7-998c2050b2b6@eisentraut.org обсуждение исходный текст |
Ответ на | Re: Fix last unitialized memory warning ("Tristan Partin" <tristan@neon.tech>) |
Список | pgsql-hackers |
On 09.08.23 17:29, Tristan Partin wrote: > On Wed Aug 9, 2023 at 10:02 AM CDT, Peter Eisentraut wrote: >> On 09.08.23 10:07, Peter Eisentraut wrote: >> > On 08.08.23 17:14, Tristan Partin wrote: >> >>> I was able to reproduce the warning now on Fedora. I agree with >> the >>> patch >> >>> >> >>> - PgBenchValue vargs[MAX_FARGS]; >> >>> + PgBenchValue vargs[MAX_FARGS] = { 0 }; >> >>> >> >>> I suggest to also do >> >>> >> >>> typedef enum >> >>> { >> >>> - PGBT_NO_VALUE, >> >>> + PGBT_NO_VALUE = 0, >> >>> >> >>> to make clear that the initialization value is meant to be invalid. >> >>> >> >>> I also got the plpgsql warning that you showed earlier, but I >>> >> couldn't think of a reasonable way to fix that. >> >> >> >> Applied in v2. >> > > committed >> >> This patch has apparently upset one buildfarm member with a very old >> compiler: >> https://buildfarm.postgresql.org/cgi-bin/show_history.pl?nm=lapwing&br=HEAD >> >> Any thoughts? > > Best I could find is SO question[0] which links out to[1]. Try this > patch. committed this fix
В списке pgsql-hackers по дате отправления: