Re: Fix gcc warning in sync.c (usr/src/backend/storage/sync/sync.c)

[ cc'ing Thomas, whose code this seems to be ]

Kyotaro Horiguchi <horikyota.ntt@gmail.com> writes:
> At Sat, 9 Jul 2022 21:53:31 -0300, Ranier Vilela <ranier.vf@gmail.com> wrote in
>> sync.c: In function ¡RememberSyncRequest¢:
>> sync.c:528:10: warning: assignment to ¡PendingFsyncEntry *¢ {aka ¡struct
>> <anonymous> *¢} from incompatible pointer type ¡PendingUnlinkEntry *¢ {aka
>> ¡struct <anonymous> *¢} [-Wincompatible-pointer-types]
>> 528 |    entry = (PendingUnlinkEntry *) lfirst(cell);

> Actually, I already see the following line (maybe) at the place instead.
>> PendingUnlinkEntry *entry = (PendingUnlinkEntry *) lfirst(cell);

Yeah, I see no line matching that in HEAD either.

However, I do not much like the code at line 528, because its
"PendingUnlinkEntry *entry" is masking an outer variable
"PendingFsyncEntry *entry" from line 513.  We should rename
one or both variables to avoid that masking.

            regards, tom lane