Re: Potentially misleading name of libpq pass phrase hook

On 5/16/20 7:47 PM, Tom Lane wrote:
> Daniel Gustafsson <daniel@yesql.se> writes:
>>> On 16 May 2020, at 03:56, Michael Paquier <michael@paquier.xyz> wrote:
>>> Agreed.  PQsslKeyPassHook_<library>_type sounds fine to me as
>>> convention.  Wouldn't we want to also rename PQsetSSLKeyPassHook and
>>> PQgetSSLKeyPassHook, appending an "_OpenSSL" to both?
>> Yes, I think we should.  The attached performs the rename of the hook functions
>> and the type, and also fixes an off-by-one-'=' in a header comment which my OCD
>> couldn't unsee.
> The patch as committed missed renaming PQgetSSLKeyPassHook() itself,
> but did rename its result type, which seemed to me to be clearly
> wrong.  I took it on myself to fix that up, and also to fix exports.txt
> which some of the buildfarm insists be correct ;-)
>
>             



argh! thanks!


cheers


andrew


-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services