Re: Current enums patch
От | Tom Lane |
---|---|
Тема | Re: Current enums patch |
Дата | |
Msg-id | 9421.1175374812@sss.pgh.pa.us обсуждение исходный текст |
Ответ на | Re: Current enums patch (Andrew Dunstan <andrew@dunslane.net>) |
Ответы |
Re: Current enums patch
Re: Current enums patch Re: Current enums patch |
Список | pgsql-patches |
>>> Here's the current version of the enums patch. [ sounds of reviewing... ] Is there a specific reason for pg_enum.enumname to be type name and not type text? ISTM that type name wastes space (because most labels will probably be a lot shorter than 63 bytes) and at the same time imposes an implementation restriction that we don't need to have. It would make sense if the enum labels were treated syntactically as SQL identifiers, but they're treated as strings. And there's no particular win to be had by having a fixed-length struct, since there's no more fields anyway. Unless someone objects, I'll change this and also revert to the enumlabel name that seems to have been used originally (it was still used in the docs). It seems more readable somehow (I guess it's the lack of either ascenders or descenders in "enumname"). regards, tom lane
В списке pgsql-patches по дате отправления: