Re: Patch to fix Debian Bug #451038

On Fri, Jul 24, 2009 at 11:14 AM, Guillaume
Lelarge<guillaume@lelarge.info> wrote:

> I've tried to check different parameters but failed. The only way I found (and
> the last I tried) is using the tab count. The last because I don't like it
> either. One other way is to loop though all the tabs and check if we have an
> "SQL" tab. It should protect us enough of the issue you're talking about?

Can we set a flag at the point where we create the tabset, and check that later?

>> > New functionality:
>> >  http://archives.postgresql.org/pgadmin-hackers/2009-07/msg00036.php
>>
>> Looks OK in principle. I've got a sneaking feeling we've had issues
>> with using translated strings in SQL queries before though, but I
>> can't think what/when that was though.
>
> We do this on all statistics methods, so we can use a common DisplayStatistics
> function. I don't see another way to get this. If we had an issue with this, I
> think we would have fixed it.

OK. I think the issue I vaguely recall was in some other
(non-statistics) code, but as I say, I can't recall the details.


--
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com