Re: BUG: pgScript NOT thread safe!!

That was my thought Ashesh - plus we could push out 1.10.1 pretty soon
with a long-term solution.

On 6/25/09, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
> Hi Mickael/Dave,
>
> Mickael Deloison wrote:
>> 2009/6/25 Magnus Hagander <magnus@hagander.net>:
>>> Ashesh Vashi wrote:
>>>>  Hi Dave,
>>>>
>>>> This patch does the job.
>>>> But, it will not be able disable to toolbar buttons on each windows.
>>>> Introduced a static variable of type wxMutex for these operations.
>>>>
>>>> Please take a look at it.
>>> I'd rather see something that throws up a messagebox informing the user
>>> that parallel execution of pgscript is not supported, if this is the
>>> route we have to go down.
>>>
>>> --
>>>  Magnus Hagander
>>>  Self: http://www.hagander.net/
>>>  Work: http://www.redpill-linpro.com/
>>>
>>
>> Hi,
>>
>> Very sorry for this bug. I did not take into account the case when one
>> uses 2 or more Query tool windows. If one launches two windows, it
>> will create two pgsApplication. However, it will use the same
>> Flex/Bison parser. Actually I can''t do anything about Flex & Bison
>> not supporting multiple threads.
>>
>> So the only immediate fix I see is the one provided by Ashesh plus
>> showing a message box when a script is running saying that a script is
>> already running (Magnus suggestion). I do not currently have a
>> development environment up-to-date: Ashesh, could you add the message
>> box please?
> I agree.
> But, as the release is in one/two days, I did not want to introduce any
> new message. :(
> (It will be added work for the translations at 11'o clock.)
> If you still insist, I can send the updated patch.
>
> --
> Thanks & Regards,
> Ashesh Vashi
>
> EnterpriseDB INDIA: http://www.enterprisedb.com
>


-- 
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com