Re: Dialogs review

On Wed, Jul 9, 2008 at 10:51 PM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:
> Guillaume Lelarge a écrit :
>>
>> [...]
>> I tend to prefer the "one patch for each dialog" approach, but I would
>> like to know your thoughts on this.
>>
>
> Here is the first one, dlgAggregate.xrc.

Cool. Testing on Mac, there are a couple of minor issues.

- There needs to be more of a border around the panes and between the
contorls. The controls are very tight to the top, bottom and sides of
the dialog (to the extend that the "I'm active" glow around controls
is cut off on the top and right hand sides for instance. Similar
eclipsing can be seen between controls. We probably just need an extra
2d or so everywhere.

- When resizing on the definition pane, the height of the list box
increases, but doesn't decrease, so if you shrink the dialogue again,
the controls at the bottom of the tab get hidden. The same does not
happen on the properties page where the comments textbox resizes
correctly.

Aside from that, it does look good. Resizing of labels in different
languages works nicely, and everything looks nice and consistent.

Nice work :-)

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com