Re: Please claim review items for commit fest!

On Wed, Jul 2, 2008 at 11:44 AM, Marko Kreen <markokr@gmail.com> wrote:
> On 7/2/08, Dave Page <dpage@pgadmin.org> wrote:
>> On Wed, Jul 2, 2008 at 11:37 AM, Marko Kreen <markokr@gmail.com> wrote:
>>  > I don't understand one aspect - if I'm unfamiliar with Postgres
>>  > and cannot do full review or am familiar but cannot do full
>>  > review due to time aspects but still want to throw some quick
>>  > comments, should I register on wiki?  And potentially make some
>>  > actual reviewers to skip the patch?
>>
>> In that situation, just add your comments to the wiki page using the
>>  appropriate template, but don't bother to list yourself as a reviewer
>>  (for the very reason you suggest).
>
> The comments should go to wiki?  Not mailing list?

It's a fine line (and slightly bendy line)  - but simple comments can
go on the wiki, discussion should go to the list and be referenced
from the wiki.

For example, see the 'returned for feedback' section at the end of the
last commit fest: http://wiki.postgresql.org/wiki/CommitFest:2008-05


-- 
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com