Re: Bug in 9.0Alpha4

Hi,<br />    I think, this should be the probable fix.<br /><br />There is agg_order in ParseFuncOrColumn, which should
getpassed on to transformAggregateCall and that should be placed in this call, instead of agg->aggorder.<br /><br
/>Thanks,<br/>Gokul.<br /><br /><div class="gmail_quote">On Tue, Mar 16, 2010 at 5:19 PM, Gokulakannan Somasundaram
<spandir="ltr"><<a href="mailto:gokul007@gmail.com">gokul007@gmail.com</a>></span> wrote:<br /><blockquote
class="gmail_quote"style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Hi,<br/>   I noticed a problem with the source code of 9.0Alpha 4. In parse_agg.c, there is a call made to
transformSortClause.<br /><br /><pre><font size="4">00098     torder = <a
href="http://doxygen.postgresql.org/parse__clause_8c.html#53199c36a198b5acf15a26fbd7311f79"
target="_blank">transformSortClause</a>(pstate,<br/> 

<a name="12766cf044e97507_l00099"></a>00099                                  agg-><a
href="http://doxygen.postgresql.org/structAggref.html#f477b6dc44bd60585cabf8608dcf2047"target="_blank">aggorder</a>,<br
/><aname="12766cf044e97507_l00100"></a>00100                                  &tlist,<br /> 

<a name="12766cf044e97507_l00101"></a>00101                                  <span>true</span> <span>/* fix unknowns
*/</span>,<br /><a name="12766cf044e97507_l00102"></a>00102                                  <span>true</span> <span>/*
forceSQL99 rules */</span> );<br /> 

<a name="12766cf044e97507_l00103"></a>00103 </font><br /><br /><br /></pre>   Here agg->aggorder should be a List of
SortGroupClausepointers, whereas transformSortClause expects the second argument as a list of SortBy pointers. I
verifiedthe doxygen code by downloading the 9.0alpha4 version. I am trying to understand this piece of code, while i
thoughti should report this bug.<br /><br />Thanks,<br />Gokul.<br /></blockquote></div><br />