Re: pgsql: Harmonize reorderbuffer parameter names.

Peter Geoghegan <pg@bowt.ie> writes:
> Harmonize reorderbuffer parameter names.

I'm confused about this, because it didn't fix the (ahem) poster-child
case?

-extern void ReorderBufferAssignChild(ReorderBuffer *, TransactionId, TransactionId, XLogRecPtr commit_lsn);
-extern void ReorderBufferCommitChild(ReorderBuffer *, TransactionId, TransactionId,
+extern void ReorderBufferAssignChild(ReorderBuffer *rb, TransactionId xid,
+                                    TransactionId subxid, XLogRecPtr lsn);
+extern void ReorderBufferCommitChild(ReorderBuffer *rb, TransactionId, TransactionId,
                                     XLogRecPtr commit_lsn, XLogRecPtr end_lsn);

ReorderBufferAssignChild is better, but ReorderBufferCommitChild is still
short some parameter names.

            regards, tom lane