Re: pgsql: Improve wording of some pg_upgrade failure reports.
От | Peter Eisentraut |
---|---|
Тема | Re: pgsql: Improve wording of some pg_upgrade failure reports. |
Дата | |
Msg-id | 92276bad-c850-4207-4863-96ec60116ee1@enterprisedb.com обсуждение исходный текст |
Ответ на | pgsql: Improve wording of some pg_upgrade failure reports. (Tom Lane <tgl@sss.pgh.pa.us>) |
Ответы |
Re: pgsql: Improve wording of some pg_upgrade failure reports.
|
Список | pgsql-committers |
On 29.04.21 21:40, Tom Lane wrote: > Improve wording of some pg_upgrade failure reports. > > Don't advocate dropping a whole table when dropping a column would > serve. While at it, try to make the layout of these messages a > bit cleaner and more consistent. I don't understand how this makes the message layout cleaner. For example, this @@ -456,10 +458,10 @@ old_11_check_for_sql_identifier_data_type_usage(ClusterInfo *cluster) output_path)) { pg_log(PG_REPORT, "fatal\n"); - pg_fatal("Your installation contains the \"sql_identifier\" data type in user tables\n" - "and/or indexes. The on-disk format for this data type has changed, so this\n" - "cluster cannot currently be upgraded. You can remove the problem tables or\n" - "change the data type to \"name\" and restart the upgrade.\n" + pg_fatal("Your installation contains the \"sql_identifier\" data type in user tables.\n" + "The on-disk format for this data type has changed, so this\n" + "cluster cannot currently be upgraded. You can\n" + "drop the problem columns and restart the upgrade.\n" "A list of the problem columns is in the file:\n" " %s\n\n", output_path); turns a message with uniform line length layout into a message with random line lengths. What is the rationale behind this?
В списке pgsql-committers по дате отправления: