Re: [PATCH] Logical decoding of TRUNCATE

On 25/01/18 08:26, Thomas Munro wrote:
> On Wed, Jan 24, 2018 at 6:47 AM, Marco Nenciarini
> <marco.nenciarini@2ndquadrant.it> wrote:
>> Version 16 attached.
> 
> Hi Marco,
> 
> FYI this version doesn't compile:
> 
> worker.c: In function ‘apply_handle_truncate’:
> worker.c:888:39: error: ‘cascade’ undeclared (first use in this function)
>   relid = logicalrep_read_truncate(s, &cascade, &restart_seqs);
>                                        ^
> 

Indeed.

We also found one more issue - the truncate done by logical replication
worker is not logically logged which would break cascading.

I expect Marco to send new version shortly with both of these fixed.

-- 
  Petr Jelinek                  http://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services