Re: New GUC to sample log queries

On 11/19/18 2:57 AM, Michael Paquier wrote:
> On Sun, Nov 18, 2018 at 12:18:33PM +0100, Dmitry Dolgov wrote:
>> Since it's hard to come up with a concise name that will mention sampling rate
>> in the context of min_duration_statement, I think it's fine to name this
>> configuration "log_sample_rate", as long as it's dependency from
>> log_min_duration_statements is clearly explained in the documentation.
> 
> log_sample_rate looks fine to me as a name.

That seems far too short to me - the name should indicate it applies to 
statement logging. I'd say log_statement_sample_rate is better.

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services