Re: row filtering for logical replication

As there is a new version, I would like to wait for a few more days

before committing. I am planning to commit this early next week (by

Tuesday) unless others or I see any more things that can be improved.

I would once like to mention the replica identity handling of the

patch. Right now, (on HEAD) we are not checking the replica identity

combination at DDL time, they are checked at execution time in

CheckCmdReplicaIdentity(). This patch follows the same scheme and

gives an error at the time of update/delete if the table publishes

update/delete and the publication(s) has a row filter that contains

non-replica-identity columns. We had earlier thought of handling it at

DDL time but that won't follow the existing scheme and has a lot of

complications as explained in emails [1][2]. Do let me know if you see

any problem here?