Re: bug in citext's upgrade script for parallel aggregates

On 07/09/2016 05:42 AM, David Rowley wrote:
> On 30 June 2016 at 03:49, Robert Haas <robertmhaas@gmail.com> wrote:
>> On Sat, Jun 25, 2016 at 3:44 AM, Andreas Karlsson <andreas@proxel.se> wrote:
>>> On 06/24/2016 01:31 PM, David Rowley wrote:
>>>> Seems there's a small error in the upgrade script for citext for 1.1
>>>> to 1.2 which will cause min(citext) not to be parallel enabled.
>>>>
>>>> max(citext)'s combinefunc is first set incorrectly, but then updated
>>>> to the correct value. I assume it was meant to set the combine
>>>> function for min(citext) instead.
>>>>
>>>> Fix attached. I've assumed that because we're still in beta that we
>>>> can get away with this fix rather than making a 1.3 version to fix the
>>>> issue.
>>>
>>> Yes, this is indeed a bug.
>>
>> Since we've already released beta2, I think we need to do a whole new
>> extension version.  We treated beta1 as a sufficiently-significant
>> event to mandate a version bump, so we should do the same here.
>
> Ok, good point. Patch attached.

Thanks!

I tested the patch and it looks good.

Andreas