Re: Patch for "Panel for Joins in the Graphic Query Builder"
| От | Ashesh Vashi |
|---|---|
| Тема | Re: Patch for "Panel for Joins in the Graphic Query Builder" |
| Дата | |
| Msg-id | 8cf965d30812020002o5e90adf0kb8bd5aa36006c162@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: Patch for "Panel for Joins in the Graphic Query Builder" ("Dave Page" <dpage@pgadmin.org>) |
| Ответы |
Re: Patch for "Panel for Joins in the Graphic Query Builder"
Re: Patch for "Panel for Joins in the Graphic Query Builder" |
| Список | pgadmin-hackers |
Hi Dave Page,
Please find the updated patch.
Only issue, I can see with the combobox within the Grid, is until you loose the focus
(by either pressing return or moving to other cell), the value is not getting updated
for that particular join
Now onwards,
* For single left click, row will be selected, but the "joins panel" will be activate.
* For double left click, "Joins panel" will be selected and the corresponding row in
the list too.
Thanks & Regards,
Ashesh Vashi
Please find the updated patch.
ThanksWow - that's a whole lot more code than I was expecting (and explains
why it took somewhat longer than I planned). What I meant, was that I
just wanted a replacement dialogue for the existing one. What you've
done is reimplement the join handling, in what I think is a *much*
nicer way :-)
Done
The only issues I've seen while testing (on Windows), are:
- The Join label doesn't update on the diagram if you change the join
type unless you click on the drawing canvas afterwards.
Only issue, I can see with the combobox within the Grid, is until you loose the focus
(by either pressing return or moving to other cell), the value is not getting updated
for that particular join
In fact, I implemented this feature on double click.
- Selecting a join should select the corresponding row in the list.
Now onwards,
* For single left click, row will be selected, but the "joins panel" will be activate.
* For double left click, "Joins panel" will be selected and the corresponding row in
the list too.
Done
- You are missing updates to include/images/module.mk and
include/gqb/module.mk. The images should also be added to the VC++
project file.
Thanks & Regards,
Ashesh Vashi
В списке pgadmin-hackers по дате отправления: