On 19.03.22 05:14, Julien Rouhaud wrote:
> On Fri, Mar 18, 2022 at 03:09:59PM -0700, Andres Freund wrote:
>> Hi,
>>
>> On 2022-03-18 20:28:58 +0100, Peter Eisentraut wrote:
>>> Why does your patch introduce a function check_icu_locale() that is only
>>> called once? Did you have further plans for that?
>>
>> I like that it moves ICU code out of dbcommands.c
>
> Yes, it seemed cleaner this way. But more importantly code outside pg_locale.c
> really shouldn't have to deal with ICU specific version code.
>
> I'm attaching a v2, addressing Peter and Tom comments to not duplicate the old
> ICU versions attribute function. I removed the ICU locale check entirely (for
> consistency across ICU version) thus removing any need for ucol.h include in
> initdb.
committed