Re: Relation bulk write facility

On 23/02/2024 17:15, Tom Lane wrote:
> Heikki Linnakangas <hlinnaka@iki.fi> writes:
>> Buildfarm animals 'sifaka' and 'longfin' are not happy, I will investigate..
> 
> Those are mine, let me know if you need local investigation.

Thanks, the error message was clear enough:

> bulk_write.c:78:3: error: redefinition of typedef 'BulkWriteState' is a C11 feature [-Werror,-Wtypedef-redefinition]
> } BulkWriteState;
>   ^
> ../../../../src/include/storage/bulk_write.h:20:31: note: previous definition is here
> typedef struct BulkWriteState BulkWriteState;
>                               ^
> 1 error generated.

Fixed now, but I'm a bit surprised other buildfarm members nor cirrus CI 
caught that. I also tried to reproduce it locally by adding 
-Wtypedef-redefinition, but my version of clang didn't produce any 
warnings. Are there any extra compiler options on those animals or 
something?

-- 
Heikki Linnakangas
Neon (https://neon.tech)