Re: On login trigger: take three

> On 11 Nov 2021, at 07:37, Greg Nancarrow <gregn4422@gmail.com> wrote:

> I've attached an updated patch, that essentially reinstates the v19
> patch

Thanks!  I've only skimmed it so far but it looks good, will do a more thorough
review soon.

+        This flag is used to avoid extra lookups on the pg_event_trigger table during each backend startup.
This should be <structname>pg_event_trigger</structname>.  Sorry, missed that
one at that last read-through.

> - dathaslogintriggers -> dathasloginevttriggers flag rename (too
> long?)

I'm not crazy about this name, "evt" is commonly the abbreviation of "event
trigger" (used in evtcache.c etc) so "dathasloginevt" would IMO be better.
That being said, that's still not a very readable name, maybe someone else has
an even better suggestion?

--
Daniel Gustafsson        https://vmware.com/