Re: repmgr.service

On Dec 17, 2015, at 12:25 PM, Martín Marqués <martin@2ndquadrant.com> wrote:

Hi,

I see this hasn't been committed yet into the pgrpms git repo.

Is it under review? If so I can say the changes are good, and if needed
I can send over a patch for easy applying.

Regards,


El 13/11/15 a las 22:59, Justin King escribió:

Please modify the repmgr-9.x.service files for the packages.

The service files currently have:

   ExecStop=/usr/bin/kill -TERM ${PIDFILE}
   ExecReload=/usr/bin/kill -HUP ${PIDFILE}


/bin/kill does not accept files, you may be thinking of /bin/pkill -f

Replace them with:

   ExecStop=/usr/bin/kill -TERM $MAINPID
   ExecReload=/usr/bin/kill -HUP $MAINPID


$MAINPID is a special systemd provided variable that references the
known PID of the process

And add the following under the [Service] section:

   PIDFile=/var/run/repmgr/repmgrd-9.x.pid


This prevents systemd from guessing what the PID is and being wrong when
Type=forking

As it stands now `systemctl stop repmgrd` and `systemctl reload repmgrd`
will always fail.

Justin

--
Martín Marqués                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services


--
Sent via pgsql-pkg-yum mailing list (pgsql-pkg-yum@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum